Open registration is disabled at the moment due to spam.If you need a new account, please contact Keto on oftc.net IRC and provide your desired username and email.
This Bugzilla instance is no longer in active use, so you should only need an account if you wish to use the Sailfish OS community OBS.
Bug 100 - Improve spectacle support for macros
Summary: Improve spectacle support for macros
Status: RESOLVED FIXED
Alias: None
Product: Mer Integration Tools (MINT)
Classification: Unclassified
Component: BOSS (show other bugs)
Version: unspecified
Hardware: Other Mer
: Undecided normal
Assignee: Marko Saukko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-10 12:04 UTC by David Greaves
Modified: 2012-02-24 08:57 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Greaves 2012-01-10 12:04:29 UTC 
The yaml file should provide better macro support:
1) structure the template to support lua
2) allow simple macro values to be specified in yaml

1) lua in the >> macros section will only work with keys that precede it in the spec file. This means that lua can't reference %{name}, %{version} etc.

2) Some macro values should be set in the yaml. Acceptance criteria is simple values, not any arbitrary multi-line macro.
Comment 1 Marko Saukko 2012-02-24 08:57:46 UTC 
3 Changes made for this:

* Added Macros support for spectacle .yaml
https://meego.gitorious.org/~sage/meego-developer-tools/sages-spectacle/commit/f4c3cbe0220b1b9c500b3b5ea7dd73e9840356ad

* Move name above the macros section
https://meego.gitorious.org/~sage/meego-developer-tools/sages-spectacle/commit/e92665bb944db44e95da1789254eba8d80de7753

* Add Macros2 before the %prep section in rpm.
https://meego.gitorious.org/~sage/meego-developer-tools/sages-spectacle/commit/00c2d0422906fc2d94cf4ada659ce314976f9beb

Let me know if there is more in this bug that needs changes.